unnecessary log messages for ssh plugin

[pradeepmantha]

The below messages are not needed for XSEDE tutorial.

05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the walltime_limit attribute. It's not supported by SSH.
05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the total_cpu_count attribute. It's not supported by SSH.
05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the spmd_variation attribute. It's not supported by SSH.

[andre-merzky]

Aren't those messages only visible when SAGA_VERBOSE is set? ::

self.pi.log_warning("Silently ignoring the walltime_limit attribute. It's not supported by SSH.")

But, FWIW, job description attributes should never be silently ignored: if they are specified, then they are likely specified for a reason, and not honoring them will likely cause the application to misbehave.

My $0.02,

Andre.

[pradeepmantha]

Yes! The SAGA_VERBOSE is not set and still I see these messages.

On Sat, May 26, 2012 at 8:01 AM, Andre Merzky
[email protected]
wrote:

Aren't those messages only visible when SAGA_VERBOSE is set? ::

   self.pi.log_warning("Silently ignoring the walltime_limit attribute. It's not supported by SSH.")

But, FWIW, job description attributes should never be silently ignored: if they are specified, then they are likely specified for a reason, and not honoring them will likely cause the application to misbehave.

My $0.02,

 Andre.

---

Reply to this email directly or view it on GitHub:
#51 (comment)

[oweidner]

Pradeep,

this has been fixed in MASTER a while ago? Let me know if not.

Cheers,
Ole

On May 25, 2012, at 8:36 PM, pradeepmantha wrote:

The below messages are not needed for XSEDE tutorial.

05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the walltime_limit attribute. It's not supported by SSH.
05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the total_cpu_count attribute. It's not supported by SSH.
05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the spmd_variation attribute. It's not supported by SSH.

---

Reply to this email directly or view it on GitHub:
#51

[oweidner]

I can make these "DEBUG" messages instead of "WARNING", so they only show up with SAGA_VERBOSE=5 or higher.

[andre-merzky]

Silently ignoring job attributes is not good -- if the attribs are specified, they are so for a reason...::

merzky@thinkie:~/saga/bliss (master $%) $ ack 'Silently ignoring'
bliss/plugins/ssh/process.py
27:            self.pi.log_debug("Silently ignoring the walltime_limit attribute. It's not supported by SSH.")
30:            self.pi.log_debug("Silently ignoring the total_cpu_count attribute. It's not supported by SSH.")
33:            self.pi.log_debug("Silently ignoring the number_of_processes attribute. It's not supported by SSH.")
36:            self.pi.log_debug("Silently ignoring the spmd_variation attribute. It's not supported by SSH.")
39:            self.pi.log_debug("Silently ignoring the project attribute. It's not supported by SSH.")
42:            self.pi.log_debug("Silently ignoring the queue attribute. It's not supported by SSH.")