Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Add reference to accessList in the docs/examples #1320

Open
gabrielfior opened this issue Sep 4, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@gabrielfior
Copy link

What is needed?

In our repo we are using Safe as the entity holding funds for some of our agents. For some contract interactions, it failed since the parameter accessList was missing (see this for rationale, transaction fails due out-of-gas error).

We realized it was missing from the references below:

I would suggest adding a reference to this in the README of this repo and/or somewhere else in the documentation.

Background

For reference, here is the relevant PR where we add accessList (link).

@Uxio0
Copy link
Member

Uxio0 commented Sep 17, 2024

since the parameter accessList was missing

Where should we add the parameter?

@gabrielfior
Copy link
Author

We add the parameter to the TxParams object, see https://github.com/gnosis/prediction-market-agent-tooling/pull/379/files#diff-1d1cce5700d8a183511739e11739daa01a18da8a7ea20d6b65303fc837bb19a0L132.

I'm not saying you should change anything in the code, I would add a hint to the reader (on any README file) saying that access_list might be required when executing transactions with Safe's having multiple signers.

@Uxio0
Copy link
Member

Uxio0 commented Sep 18, 2024

I would add a hint to the reader (on any README file) saying that access_list might be required when executing transactions with Safe's having multiple signers

Why it might be required? It could be more optimal, and maybe required in an edge case, but in my personal case I was never forced to use it

@github-staff github-staff deleted a comment from GenaroSalomone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants