[Add App] Coinrule Multiswap

[ogiberstein]

Entry type

• New addition

App info

URL: https://safeapp.coinrule.com/

Manifest.json URL: https://web.coinrule.com/manifest.json

Name: Coinrule Multiswap

Description: Coinrule's Multiswap lets you sell dozens and hundreds of dust tokens in just a few clicks.

Icon (PNG, 180x180): Icon
It's minified via https://tinypng.com: yes

Homepage: coinrule.com
Twitter: coinrulehq
GitHub: We use Gitlab
Discord: Discord

App supports batching multiple transactions via Safe: yes

Supported networks

- Mainnet

Revision checks

• [n/a - no smart contracts ] Used smart contracts were audited.
• You have implemented the app using the Safe Apps SDK
• Your Safe App includes a manifest.json file at the root with the required data
• The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
• The app auto-connects to the Safe as a wallet
• It doesn't try to connect to the browser wallet (e.g. MetaMask)
• You are able to trigger and execute one transaction with a Safe.
• RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

N/A - No Smart Contracts used

Code for review

TBC - this is on Gitlab

Team information

Company: Coinrule

Official website: Coinrule

Point of contact: Oleg Giberstein

Email/Telegram: [email protected] / @oleggiberstein

[kirkkonen]

This submission was reviewed and approved by the product team.

[tmjssz]

I reviewed the code and it looks good to me in general. There are a couple of things I would suggest for improvement:

Frontend

• Remove unused/deprecated dependencies, such as safe-global/auth-kit or @safe-global/safe-core-sdk
• @safe-global/safe-apps-sdk imports are present in the project but missing in the dependency list
• Avoid console.log ’s for debugging in production code (e.g. in SafeConvertCoins.tsx line 207-208)
• Use useSafeAppsSDK hook in components to get the sdk instance. It can be imported from the @safe-global/safe-apps-react-sdk package which is already in the dependency list, but not used
• Import from the top-level package if possible, instead of using internal paths:

  // e.g. instead of this
  import { ChainInfo } from '@safe-global/safe-apps-sdk/src/types';
  import { SafeInfoExtended } from '@safe-global/safe-apps-sdk/src/types/sdk';
  
  // just do this
  import { ChainInfo, SafeInfoExtended } from '@safe-global/safe-apps-sdk'

• Increase test coverage

Backend

• Migrate from @safe-global/safe-core-sdk-types (deprecated) to @safe-global/types-kit

[ogiberstein]

Many thanks for the feedback Tim. Do we need to action these items before we can get listed or none of them is critical? Best, Oleg *Oleg Giberstein* COO Co-Founder *Linkedin <https://www.linkedin.com/in/giberstein>* *Twitter <https://twitter.com/ogiberstein>* <https://coinrule.com/> Office One, 1 Coldbath Square, EC1R 5HL, London <https://www.forbes.com/sites/davidprosser/2021/09/27/coinrule-bags-big-name-investors-for-its-automated-crypto-trading-platform/?sh=3b12f2ac258f>

…

On Mon, 25 Nov 2024 at 17:40, Tim ***@***.***> wrote: I reviewed the code and it looks good to me in general. There are a couple of things I would suggest for improvement: Frontend - Remove unused/deprecated dependencies, such as safe-global/auth-kit or @safe-global/safe-core-sdk - @safe-global/safe-apps-sdk imports are present in the project but missing in the dependency list - Avoid console.log ’s for debugging in production code (e.g. in SafeConvertCoins.tsx <https://gitlab.com/coinrule-v2/dev/coinrule.com/-/blob/master/frontend/src/design-system/templates/ConvertCoins/SafeConvertCoins.tsx?ref_type=heads#L207-208> line 207-208) - Use useSafeAppsSDK hook in components to get the sdk instance. It can be imported from the @safe-global/safe-apps-react-sdk ***@***.***/safe-apps-react-sdk> package which is already in the dependency list, but not used - Import from the top-level package if possible, instead of using internal paths: // e.g. instead of thisimport { ChainInfo } from ***@***.***/safe-apps-sdk/src/types';import { SafeInfoExtended } from ***@***.***/safe-apps-sdk/src/types/sdk'; // just do thisimport { ChainInfo, SafeInfoExtended } from ***@***.***/safe-apps-sdk' - Increase test coverage Backend - Migrate from @safe-global/safe-core-sdk-types (deprecated) to @safe-global/types-kit — Reply to this email directly, view it on GitHub <#409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYSXPNT6XF64GKSURV4UG32CNOIXAVCNFSM6AAAAABQ6TBCMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJYGY2TAMBZGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>