Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UNCX Lockers App #392

Open
8 tasks done
alex-unicrypt opened this issue Sep 3, 2024 · 4 comments
Open
8 tasks done

Add UNCX Lockers App #392

alex-unicrypt opened this issue Sep 3, 2024 · 4 comments

Comments

@alex-unicrypt
Copy link

alex-unicrypt commented Sep 3, 2024

Entry type

  • New addition

App info

URL:

https://safe-lockers.uncx.network

Manifest.json URL:

https://safe-lockers.uncx.network/manifest.json

Name:

UNCX Liquidity Lockers

Description:

Icon (PNG, 180x180):
Unknown

Homepage: https://uncx.network
Twitter: https://x.com/UNCX_token
GitHub: https://github.com/uncx-network
Telegram: https://t.me/uncx_token

App supports batching multiple transactions via Safe: no

Supported networks

- Mainnet
- Base
- Arbitrum
- Polygon
- BNB Chain
- Avalanche
- IOTA
- Telos
- Sepolia

Revision checks

  • Used smart contracts were audited.
  • You have implemented the app using the Safe Apps SDK
  • Your Safe App includes a manifest.json file at the root with the required data
  • The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
  • The app auto-connects to the Safe as a wallet
  • It doesn't try to connect to the browser wallet (e.g. MetaMask)
  • You are able to trigger and execute one transaction with a Safe.
  • RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

Code for review

Team information

Company: UNCX Network

Official website: https://uncx.network/
Point of contact: Antoine Chaveron
Email/Telegram: [email protected] / @Chvant

@kirkkonen
Copy link

This one was reviewed and approved by the product team.

@katspaugh katspaugh moved this to Ready for QA in Web Squad Sep 3, 2024
@francovenica
Copy link

The app doesn't show an icon:
image

It doesn't seems to work for sepolia, maybe you have a different URL for it?
image

The "sushi" URL takes to a 404 in sushi. Maybe you should update it to this one? "https://www.sushi.com/ethereum/pool"
image

Beyond this the rest is fine

@alex-unicrypt
Copy link
Author

Hey @francovenica! Thanks for the feedback!

Icon issue appears to be solved, at least when loading the app in a private window (https://app.safe.global/apps/custom).

Regarding V2 Sepolia - we were waiting for Uniswap to deploy on it, which they recently did, therefore Sepolia support has been added.

Pool creation links have been removed for simplicity's sake.

Please let us know if there’s anything more you'd like us to improve.

@parius parius moved this from In Progress to Ready for QA in Web Squad Nov 19, 2024
@francovenica
Copy link

Hi there @alex-unicrypt.

Yes The fixes are fine.
The logo is visible and I can use the app in sepolia now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to merge
Development

No branches or pull requests

3 participants