Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gimme.mom #388

Open
8 tasks done
Majorfi opened this issue Aug 19, 2024 · 6 comments
Open
8 tasks done

Gimme.mom #388

Majorfi opened this issue Aug 19, 2024 · 6 comments

Comments

@Majorfi
Copy link

Majorfi commented Aug 19, 2024

Entry type

  • New addition

App info

URL: gimme.mom

Manifest.json URL: https://gimme.mom/manifest.json

Name: Gimme

Description: A very simple and UX focused way to deposit tokens to earn Yield on them. Built on Yearn's vault

Icon (PNG, 180x180): https://gimme.mom/favicons/apple-icon-180x180.png
It's minified via https://tinypng.com: no

Homepage: https://gimme.mom
Twitter: https://twitter.com/built_by_mom
GitHub: https://github.com/BuiltByMom/gimme
Discord: N/A

App supports batching multiple transactions via Safe: yes

Supported networks

- Polygon
- _We expect to release a multichain version in the next two weeks_

Revision checks

  • Used smart contracts were audited.
  • You have implemented the app using the Safe Apps SDK
  • Your Safe App includes a manifest.json file at the root with the required data
  • The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
  • The app auto-connects to the Safe as a wallet
  • It doesn't try to connect to the browser wallet (e.g. MetaMask)
  • You are able to trigger and execute one transaction with a Safe.
  • RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://docs.yearn.finance/security/#third-party-audits

Code for review

https://github.com/BuiltByMom/gimme

Team information

Company: MOM
Official website: N/A
Point of contact: Major / Facu
Email/Telegram: @Majorfi / @saltyfacu

@kirkkonen
Copy link

This one was reviewed and approved by the product team.

PS: @Majorfi you didn't get back to me in the email so found this issue just now.

@Majorfi
Copy link
Author

Majorfi commented Sep 3, 2024

Oh my bad, sorry about that and thank you for the review!

@github-project-automation github-project-automation bot moved this to New issues in Web Squad Sep 4, 2024
@katspaugh katspaugh moved this from New issues to Ready for QA in Web Squad Sep 4, 2024
@francovenica
Copy link

francovenica commented Oct 4, 2024

I'm getting this error in the dev console, which makes the button at the bottom load forever
image

I get the same error using your app as a stand alone in https://gimme.mom/earn, connecting my safe or my MM chrome extension.

Let us know if you are experiencing issues in your app currently

@Majorfi
Copy link
Author

Majorfi commented Oct 9, 2024

Hey, thank you for the finding! This has been fixed!

@parius parius moved this from In Progress to Ready for QA in Web Squad Nov 19, 2024
@francovenica
Copy link

Hi there, sorry for taking so long to check this.

It does work fine now. Thanks!

@liliya-soroka
Copy link
Member

@parius the app is approved from the QA side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to merge
Development

No branches or pull requests

4 participants