Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): add provider.auto-stop-on-startup argument #346

Conversation

acouvreur
Copy link
Member

This feature adds the capability to stop unregistered running instances upon startup.

Previously, you had to stop running instances manually or issue an initial request that will shut down instances afterwards.

With this change, all discovered instances will be shutdown. They need to be registered using labels. E.g.: sablier.enable=true

@github-actions github-actions bot added the provider Issue related to a provider label Jul 4, 2024
This feature adds the capability to stop unregistered running instances upon startup.

Previously, you had to stop running instances manually or issue an initial request that will shut down instances afterwards.

With this change, all discovered instances will be shutdown. They need to be registered using labels. E.g.: sablier.enable=true

Fixes #153
@acouvreur acouvreur force-pushed the 153-services-started-with-docker-compose-wont-be-stopped-by-sablier-unless-hit-with-a-request-first branch from a973b78 to dce647f Compare July 4, 2024 01:00
@github-actions github-actions bot added the reverse-proxy Reverse proxy integration related issue label Jul 4, 2024
@acouvreur acouvreur merged commit 52a7d21 into beta Jul 4, 2024
15 of 17 checks passed
@acouvreur
Copy link
Member Author

🎉 This issue has been resolved in version 1.8.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@acouvreur acouvreur deleted the 153-services-started-with-docker-compose-wont-be-stopped-by-sablier-unless-hit-with-a-request-first branch July 8, 2024 04:26
acouvreur added a commit that referenced this pull request Oct 2, 2024
This feature adds the capability to stop unregistered running instances upon startup.

Previously, you had to stop running instances manually or issue an initial request that will shut down instances afterwards.

With this change, all discovered instances will be shutdown. They need to be registered using labels. E.g.: sablier.enable=true

Fixes #153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider Issue related to a provider released on @beta reverse-proxy Reverse proxy integration related issue
Projects
None yet
1 participant