Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions on Create Sales Order Spec #53

Open
dt2patel opened this issue Jul 22, 2024 · 0 comments
Open

Revisions on Create Sales Order Spec #53

dt2patel opened this issue Jul 22, 2024 · 0 comments

Comments

@dt2patel
Copy link
Contributor

Comments on the create sales order spec document

https://github.com/saastechacademy/foundation/blob/main/project-ideas/create-sales-order.md

2. **Order Identification:** It first checks if the order already exists in HotWax Commerce by looking for a matching Shopify order ID. If the order exists, it skips further processing.

Need to reference that we store unique Shopify id in special Shopify table

  1. "uses OrderItemAttribute to store properties associated with line items"
    We should be particular about the name "lineItemProperties" or even the exact name of the object in Shopify order JSON so that it is easy for the developer to track.

"creates OrderAttribute or OrderItemAttribute entities" is misleading. Create Shopify Order code does not create entities

"If a product is tagged as "ON_PRE_ORDER_PROD" or "ON_BACK_ORDER_PROD" in Shopify" I don't think this part is accurate with respect to line item properties. I think we should double check our understanding here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant