You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've spent some time troubleshooting, and the issue is with your defaultRemoveFormatting, which is called in this line.
What that is doing is:
The user types 1.1.
_numAsString is set to 1.1.
const _formattedValue = _format(_numAsString); is called, so _formattedValue is set to $1.1
_numAsString = removeFormatting(_formattedValue, undefined); is called with the default formatting function, which just grabs the digits from the string. So now _numAsString is set to 11.
Now the input has value of $11 instead of $1.1.
The Intl library doesn't provide a unformatter function. But there's not even a real need, since _numAsString already had the correct value and it's erased. Creating a custom unformatter function would add complexity for no gain (especially because handling i18n strings is dangerous and bug-prone).
I propose a couple ways to fix this:
Offer a prop to turn off the removeFormatter function. Essentially turn of recalculating the value after the formatter runs. That feels like an edge case.
Alternatively, just allow for the formatter to return the new _numAsString. For example in the case above it could return:
Describe the issue and the actual behavior
When using
Intl.NumberFormat
based formatting just like it's demo'ed in your docs, using decimals break the form.If you change that demo to accept 2 decimals, as currencies as used, every key stroke will multiply the value by 100.
Describe the expected behavior
It should handle cents as normal, without multiplying the value.
Provide a CodeSandbox link illustrating the issue
Open your own sandbox and just change
maximumFractionDigits: 2
to accept centsProvide steps to reproduce this issue
Type numbers with cents.
Please check the browsers where the issue is seen
I've spent some time troubleshooting, and the issue is with your
defaultRemoveFormatting
, which is called in this line.What that is doing is:
1.1
._numAsString
is set to1.1
.const _formattedValue = _format(_numAsString);
is called, so_formattedValue
is set to$1.1
_numAsString = removeFormatting(_formattedValue, undefined);
is called with the default formatting function, which just grabs the digits from the string. So now_numAsString
is set to11
.$11
instead of$1.1
.The
Intl
library doesn't provide a unformatter function. But there's not even a real need, since_numAsString
already had the correct value and it's erased. Creating a custom unformatter function would add complexity for no gain (especially because handling i18n strings is dangerous and bug-prone).I propose a couple ways to fix this:
removeFormatter
function. Essentially turn of recalculating the value after the formatter runs. That feels like an edge case._numAsString
. For example in the case above it could return:that would allow your use case where the formatter erases digits, without the need to call
removeFormatting
.We're blocked on using the
Intl
library until this is fixed. So a quick response would be greatly appreciated! Or at least a work around.Thanks!
The text was updated successfully, but these errors were encountered: