-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to python3 anf GTK3 #31
Open
stokito
wants to merge
34
commits into
ryran:master
Choose a base branch
from
stokito:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just opened them and saved. Can't guarantee that all was migrated correctly.
Also remove long ----- lines The -*- coding: utf-8 -*- is also not needed
@ryran please merge. Even if you don't have enough time for review this will be a good starting point for those who with to contribute |
The Background was nice to read but it doesn't add useful info
This was referenced Oct 28, 2023
Signed-off-by: Sergey Ponomarev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a dirty draft of the migration but it already starts, shows a window and can encrypt and decrypt!
I'm not a Python dev so probably can't make this correctly.
But I hope it will inspire you to finish the migration.
Helpful articles:
https://overtag.dk/v2/blog/first-impressions-of-gtk3-migration-in-python/
I used 2to3 tool and official PyGtk migration script https://gitlab.gnome.org/GNOME/pygobject/-/blob/master/tools/pygi-convert.sh?ref_type=heads
Fixes #29