Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bias is always searched in BlasNceSoftmaxAdapter #11

Open
mattiadg opened this issue Dec 14, 2021 · 1 comment
Open

Bias is always searched in BlasNceSoftmaxAdapter #11

mattiadg opened this issue Dec 14, 2021 · 1 comment

Comments

@mattiadg
Copy link

auto const& bias_tensor_info = output_map.get_info("bias");

As you can see in the highlighted code, the parameter "bias" is always searched in the config, but in my experience the bias doesn't exist for the output layer more often than yes. Also, when the parameter name is not found, the program just crashes with a criticalError.

As a side note, the error message doesn't show the parameter name causing the error.

@mattiadg
Copy link
Author

mattiadg commented Dec 15, 2021

As mentioned in #12, there is other code assuming the existence of this tensor. Should we create a zero bias tensor when it doesn't exist, or more cleanly check the existence of this tensor? In the second case, the retrieval of the bias tensor should be able to handle the error.
Also making another class for the case without a bias is an easy option to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant