Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DumpAlignmentJob flow #557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix DumpAlignmentJob flow #557

wants to merge 1 commit into from

Conversation

Icemole
Copy link
Collaborator

@Icemole Icemole commented Nov 19, 2024 •
edited
Loading

The flow needed the parameters 'id' and 'TASK'.

Extract of the dump.flow used by the job:

  <node filter="generic-cache" id="$(id)" name="alignment-cache" path=".../alignment.cache.$(TASK)"/>
[...]
  <node file="alignment.cache.$(TASK)" filter="speech-alignment-dump" id="$(id)" name="dumper"/>

@Icemole
Fix DumpAlignmentJob flow
9a7506c 
The flow needed the parameters 'id' and 'TASK'.
@Icemole Icemole self-assigned this Nov 19, 2024
michelwi
michelwi approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@michelwi michelwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter "TASK" is not an explicit dependence here, but is almost always used by original_alignment and new_alignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelwi michelwi michelwi approved these changes

@curufinwe curufinwe Awaiting requested review from curufinwe

@christophmluscher christophmluscher Awaiting requested review from christophmluscher

@sarahberanek sarahberanek Awaiting requested review from sarahberanek

@JackTemaki JackTemaki Awaiting requested review from JackTemaki

@moothiringote moothiringote Awaiting requested review from moothiringote

@Atticus1806 Atticus1806 Awaiting requested review from Atticus1806

At least 2 approving reviews are required to merge this pull request.

Assignees

@Icemole Icemole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icemole @michelwi