Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure in EventStream SSE #2088

Closed
kolbma opened this issue Jan 24, 2022 · 0 comments
Closed

Test failure in EventStream SSE #2088

kolbma opened this issue Jan 24, 2022 · 0 comments
Labels
triage A bug report being investigated

Comments

@kolbma
Copy link
Contributor

kolbma commented Jan 24, 2022

Is anybody of you using EventStream SSE of Rocket and has seen any inexplicable outputs??!!

If you can give some hints see here...
rocket-org#5

Description

While the test response::stream::sse::sse_tests::test_heartbeat is repeated multiple times in the test garnish and has been always successful, I got now one time an assertion failed.

Is anybody of you using EventStream SSE of Rocket and has seen any inexplicable outputs??!!

The result of the test looks like a memory corruption or a race in setting memory boundaries:

failures:

---- response::stream::sse::sse_tests::test_heartbeat stdout ----
thread 'response::stream::sse::sse_tests::test_heartbeat' panicked at 'assertion failed: `(left == right)`
  left: `"data:hello\n:\n\n\n"`,
 right: `"data:hello\n\n"`', core/lib/src/response/stream/sse.rs:795:9


failures:
    response::stream::sse::sse_tests::test_heartbeat

test result: FAILED. 64 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 3.06s

https://github.com/kolbma/Rocket/blob/e365ab9ba423cf90864749318b548731ee9dc8d3/core/lib/src/response/stream/sse.rs#L792-L795

@kolbma kolbma added the triage A bug report being investigated label Jan 24, 2022
kolbma added a commit to kolbma/Rocket that referenced this issue Jan 24, 2022
@kolbma kolbma closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage A bug report being investigated
Projects
None yet
Development

No branches or pull requests

1 participant