Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this yours now? #4

Closed
da-mask opened this issue Sep 1, 2022 · 2 comments
Closed

Is this yours now? #4

da-mask opened this issue Sep 1, 2022 · 2 comments

Comments

@da-mask
Copy link

da-mask commented Sep 1, 2022

Shouldn't this have been a pull request on the original repo, instead of forking and putting it on the Chrome web store yourself?

@rw4lll
Copy link
Owner

rw4lll commented Sep 4, 2022

@da-mask it's not possible to make a PR without forking, as I'm not a maintainer of the original repo.
Yes, you're right. Normally this would definitely makes sense to do the way you wrote, but unfortunately, not this time.

This summer the extension was marked as a virus by chrome and disappeared from the store. The ticket with the issue was opened for several months without any updates. I've looked at the repo and found, that the last update was more than a year ago, so probably it's abandoned.

Since our team was working with livewire a lot and it was unclear, when the issue will be solved, I've decided to investigate the issue by myself and re-publish the extension ASAP to make it available for everyone again.

I thought, that probably the author will contact me to discuss about merging this updates afterwards, but on the moment it didn't happened.

Additionally I have some plans to improve this extension and currently working on it (see roadmap). On the moment the future is unclear - probably these and future updates will be merged in the main project or will become a completely separate.

@da-mask
Copy link
Author

da-mask commented Sep 4, 2022

I understand it took a lot of work to fix, and appreciate you doing so and re-releasing this extension. Many teams have become reliant on this tool.

I do also think you have to be careful when releasing work based on other Open source projects. I note the author of the original actually would have preferred a PR, as mentioned here. I just hope you made enough effort to reach out to them before taking it over.

Cheers.

@da-mask da-mask closed this as completed Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants