Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRC validation #5

Open
timoline opened this issue Mar 4, 2017 · 6 comments
Open

CRC validation #5

timoline opened this issue Mar 4, 2017 · 6 comments

Comments

@timoline
Copy link

timoline commented Mar 4, 2017

Do we need CRC validation?

example code
https://github.com/robertklep/node-dsmr-parser
@ruudverheijden
Copy link
Owner

Didn't know it was in the DSMR specs but I think it's fine to add it ;)
Can you make a pull request for it?

@timoline
Copy link
Author

timoline commented Mar 5, 2017 •
edited
Loading

I wish I could :-)
I'm just a beginner...I mean I tried, but still no succes

@timoline
Copy link
Author

timoline commented Jul 7, 2018 •
edited
Loading

found this fork, which implemented crc, maybe you can get the code and implement it?
https://github.com/jorith88/node-p1-reader/commits/master

thanks in advanced

@ruudverheijden
Copy link
Owner

Thanks! Will have a look after my holiday ;)

@timoline
Copy link
Author

timoline commented Sep 1, 2018

Hi, can you reopen this one? thx

@ruudverheijden
Copy link
Owner

Done

@ruudverheijden ruudverheijden reopened this Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timoline @ruudverheijden