Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to log (failed) authentication attempts to enable the usage of tools like fail2ban and crowdsec #435

Open
netw0rk-noob opened this issue Jul 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@netw0rk-noob
Copy link

netw0rk-noob commented Jul 1, 2024

Is your feature request related to a problem? Please describe.
Right now everyone can connect to the server repeatedly as often as he wants to try bruteforcing the pre-shared key which is needed to authenticate to the server. Besides that, denial-of-service attacks are possible. That is due to the fact that rustdesk does not log (failed) authentication attempts (with source ip addresses) anywhere which would make it possible to use tools like fail2ban or crowdsec to ban repeated offenders.

Describe the solution you'd like
I'd like rustdesk-server to add an option to enable auth logging which would log (failed) authentication attempts to a logfile which could be used by above mentioned daemons to ban ip adresses which repeatedly fail to authenticate against the server.

Describe alternatives you've considered
I did enable debug logs by adding Environment="RUST_LOG=debug" to the systemd unit which is starting rustdesk-server according to the FAQ but since that logs all connections and doesnt differentiate between successful/failed authentications using fail2ban on it creates the risk of banning legitimate users. That risk gets even greater when considering the fact that a successfully established remote control session logs 8 lines containing the source ip address while an illegitimate connection (trying to connect with a wrong key specified in the Client settings under network -> ID/Relay server -> Key) only logs 2 lines.

@netw0rk-noob netw0rk-noob added the enhancement New feature or request label Jul 1, 2024
@ArtDmn
Copy link

ArtDmn commented Jul 9, 2024

It is definitely something that would be useful, I'm looking forward this exact same feature too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants