Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would it make sense to add a way to maximize the window? #129

Closed
pedrocr opened this issue Jan 31, 2017 · 4 comments
Closed

Would it make sense to add a way to maximize the window? #129

pedrocr opened this issue Jan 31, 2017 · 4 comments
Labels
DS - macos

Comments

@pedrocr
Copy link
Contributor

pedrocr commented Jan 31, 2017

Windowing systems often have a WM hint or similar mechanism to get the operating system to resize the window to it's maximum dimensions on the screen. Would adding this to the Window API make sense?
@pedrocr pedrocr mentioned this issue Jan 31, 2017
Merged
@francesca64
Copy link
Member

This is only implemented on X11 and Wayland, though Wayland doesn't implement Window::set_maximized.

@elinorbgr elinorbgr mentioned this issue Dec 14, 2017
Closed
@francesca64
Copy link
Member

Thanks to #457, this is now implemented on Windows.

@edwin0cheng edwin0cheng mentioned this issue Apr 14, 2018
Merged
@francesca64
Copy link
Member

francesca64 commented Apr 14, 2018 •
edited
Loading

set_maximized was implemented on Wayland back in #383.

@francesca64
Copy link
Member

With #465, this is now implemented everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DS - macos
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pedrocr @francesca64