-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise min rustc version to 1.32.0 for version 0.7 #719
Comments
Interesting; 1.22 still works on Linux at least but sounds like it might be time we update the min version. I'll leave this open for a while though in case anyone has objections? |
Looking at libc's Travis config, it seems they officially support Rust 1.13. Is this not true on osx? |
@vks they do, but the latest version of the libc crate on osx now only supports 1.24.0+ due to using a constant function. |
Thanks @erickt! I think the best way forward is to wait for a libc fix. |
There is another reason we may want to raise the minimum: lazy-static requires We don't actually depend on this, but Maybe this isn't sufficient reason to require a later compiler, however? |
According to initial feedback on reddit, 1.24.1 is pretty-much the oldest anyone cares about, and most (or all) are happy to use the latest stable release (at least for applications). This makes me happier about bumping the minimum to 1.28, which we might want for rust-random/getrandom#3. |
FYI, we will likely raise the minimum rustc version to 1.28 for version 0.7 of Rand. I'll leave this open in the mean-time as a place to raise objections, if necessary (so far I have seen only one minor concern). |
BTW how about going all the way down and migrate to 2018 edition? 1.28 is only two releases behind, so it may be worth considering. |
FYI we are increasing the MSRV for However, we will try to avoid depending on this compiler version in |
Edit: old title: rand does not compile on osx with rust 1.22.0
It looks like the minimum version of rust 1.22.0 no longer works with rand, due to this dependency change in libc: rust-lang/libc#1212. It's using
std::mem::size_of
as a constant function, but that was stablized in 1.24.0.edit: forgot to mention I don't personally care about 1.22, so I wouldn't care if you decided to drop support for it.
The text was updated successfully, but these errors were encountered: