-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToOwned
not implemented for Cow
as it ought to be
#100347
Labels
C-bug
Category: This is a bug.
E-needs-test
Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Comments
lcnr
added
the
T-types
Relevant to the types team, which will review and decide on the PR/issue.
label
Aug 10, 2022
Enselic
changed the title
Apr 15, 2024
ToOwned
not implemented as it ought to beToOwned
not implemented for Cow
as it ought to be
Enselic
added
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
and removed
T-types
Relevant to the types team, which will review and decide on the PR/issue.
labels
Nov 12, 2024
This works as of Rust 1.79, so I think this should be closed. |
Nice, thanks for the notice. Let's make sure there is a test for the variant in this issue. Either as part of #129541 or independently. |
Enselic
added
E-needs-test
Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
S-bug-has-test
Status: This bug is tracked inside the repo by a `known-bug` test.
labels
Nov 18, 2024
PR that adds test: #133473 |
Enselic
removed
the
S-bug-has-test
Status: This bug is tracked inside the repo by a `known-bug` test.
label
Nov 25, 2024
jhpratt
added a commit
to jhpratt/rust
that referenced
this issue
Nov 26, 2024
tests: Add regression test for recursive enum with Cow and Clone I could not find any existing test. `git grep "(Cow<'[^>]\+\["` gave no hits before this tests. Closes rust-lang#100347
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Nov 26, 2024
Rollup merge of rust-lang#133473 - Enselic:cow, r=nnethercote tests: Add regression test for recursive enum with Cow and Clone I could not find any existing test. `git grep "(Cow<'[^>]\+\["` gave no hits before this tests. Closes rust-lang#100347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: This is a bug.
E-needs-test
Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
I tried this code:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=442442eaa00a34e7c38f9d9db3654160
I expected to see this happen: it compiles successfully.
Instead, this happened: it fails to compile with the following error:
Meta
As of today's stable version 1.61.1, no versions have ever successfully accepted this code. However I believe there is nothing inherently wrong about it and I have faced this failure for such pattern multiple times already.
Workaround
You can workaround the issue by writing your
Cow
-like type.The text was updated successfully, but these errors were encountered: