-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add From<GlobError> for io::Error
impl
#64
Comments
Secondary point: I prefer the format Also, any opinion about that format would be appreciated... I could still improve it! |
This was referenced Jan 29, 2018
I would like to have this feature too. Can I implement it myself and open a pull request? This issue seems to have become stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The conversion I would suggest is:
This will keep the "pretty context" so that glob errors keep printing as:
Which is already very ergonomic.
I can do this if you OK it 😄
Benefits / Justification
The glob error is already essentially an
io::Error
with a bit of additional context. This will allow functions that returnio::Error
can use glob with?
directly which incurs (basically) no performance issues.The text was updated successfully, but these errors were encountered: