Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob follows symlinks #62

Open
aplanas opened this issue Sep 19, 2017 · 3 comments
Open

glob follows symlinks #62

aplanas opened this issue Sep 19, 2017 · 3 comments

Comments

@aplanas
Copy link

aplanas commented Sep 19, 2017

glob do not understand symlinks, and this cause problems in directories like /sys, where is frequent to have loops, and in some cases never ends.

@aplanas aplanas changed the title glob follow symlinks glob follows symlinks Sep 19, 2017
@aplanas
Copy link
Author

aplanas commented Sep 22, 2017

Any review on #63 so I can improve the code?

@andre-richter
Copy link
Member

I just hit this exact wall, looping infinitely in sys.

I think I'm not qualified to review, but when reading the code, I thought that follow_links might be a better name than follows_link.

Cheers,
Andre

@aplanas
Copy link
Author

aplanas commented Oct 16, 2017

@andre-richter I think that you are right. I updated the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants