Remove tcp stack #70
Merged
Remove tcp stack #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2022 09:33
These traits restricts implementors to only support 1 connection at a time, which only covers a small set of use cases. The new TcpConnect trait is more flexible and should be the preferred trait for implementors and users.
|
The UDP traits have the same set of problems (for example, you can only rx/tx on 1 conn at a time). I'd remove them, once they're known-broken there's no point in leaving them. |
The traits restrict the implementations too much on embedded devices. Removing them now to avoid people committing to them, and instead reintroduce them in a form that is more easily supported by drivers.
|
Great, I've removed them. @MathiasKoch I've also bumped the version to 0.2.0 and added the changelogs. |
|
Released to crates.io 🎉 |
|
Hi @Dajamante ! I think the discussion in that issue is mainly about the blocking traits. This PR only removed the async traits since I made some bad decisions in the initial design. As discussed in #69, maybe TcpListen and TcpAccept traits is the complementary of TcpConnect, but I'm not going to work on that near term due to other priorities, so feel free to have a go :) |
This was referenced Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TcpClientStack and TcpFullStack
These traits restricts implementors to only support 1connection at a time, which only covers a small set of use cases.
The new TcpConnect trait is more flexible and should be the preferred trait for implementors and users.
NOTE: