This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Fix amount parsing in GetTransactionDetail #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like there is no 0.17.2 on https://bitcoincore.org/en/releases/. I don't know what happened, how I got to using 0.17.2 - perhaps I got confused.
Turns out this amount is signed, use `SignedAmount` instead of `Amount`.
tcharding
force-pushed
the
06-13-amount-bug
branch
from
345d53c to
7952b70
Compare
In preparation for release bump the version numbers to `v0.2.0`. Also add changelogs for all crates.
tcharding
force-pushed
the
06-13-amount-bug
branch
from
b59f7f0 to
ee6525b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a field wrong, it is supposed to be signed. Also, turns out somehow I got confused that there is not such thing as Bitcoin Core v0.17.2 - switch to using v0.17.1