This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
json: Use i64 where possible
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Props to @stevenroose for the pointing out the issue and the suggested fix. It was an off the cuff suggestions so any problems created are my own. |
tcharding
force-pushed
the
09-12-use-i64
branch
from
496b294 to
6ee8c9b
Compare
tcharding
force-pushed
the
09-12-use-i64
branch
from
6ee8c9b to
57233b9
Compare
The Bitcoin Core JSONRPC API has fields marked as 'numeric'. It is not obvious what Rust type these fields should be. We want the version specific JSON types to just work (TM). 1. We use an `i64` because its the biggest signed integer on "common" machines. 2. We use a signed integer because Core sometimes returns -1. Some fields are then converted to `rust-bitcoin` types that expect a `u64` (eg sats), these are left as `u64` and we just hope Core never returns -1 for any of them.
tcharding
force-pushed
the
09-12-use-i64
branch
from
57233b9 to
23d38ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bitcoin Core JSONRPC API has fields marked as 'numeric'. It is not obvious what Rust type these fields should be.
We want the version specific JSON types to just work (TM).
i64because its the biggest signed integer on "common" machines.Some fields are then converted to
rust-bitcointypes that expect au64(eg sats), these are left asu64and we just hope Core never returns -1 for any of them.