Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fe32::ZERO const #185

Closed
wants to merge 2 commits into from
Closed

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented Jul 16, 2024

Add Fe32::ZERO const, which is the same as Fe32::Q, but with more intuitive name.
Also replace Fe32::Q to Fe32::ZERO in a few relevant places.

src/primitives/decode.rs Outdated Show resolved Hide resolved
@apoelstra
Copy link
Member

concept ACK, though several of the changes from Q to ZERO I think make the code less clear.

@optout21
Copy link
Contributor Author

Reverted some of the renames as requested.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2d2d8aa

@tcharding
Copy link
Member

tcharding commented Jul 16, 2024

Thanks for your contribution but NACK from me.

How is this better than using Fe32::Q. Also it begs the question why not have numerics for all 24 characters, and that would be horrible IMO.

@clarkmoody
Copy link
Member

I also don't see the need for this, unless I'm missing something.

@optout21
Copy link
Contributor Author

Retracting

@optout21 optout21 closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants