Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Default trait to Fe32 #187

Closed
optout21 opened this issue Jul 16, 2024 · 3 comments
Closed

Add Default trait to Fe32 #187

optout21 opened this issue Jul 16, 2024 · 3 comments

Comments

@optout21
Copy link
Contributor

optout21 commented Jul 16, 2024 •
edited
Loading

LDK uses u5 from earlier version, and during the upgrade to Fe32 the Default and Ord traits were missed (PR).

Implementation would be trivial here, it just has to be derived.
PR created to add them (#184).
This was referenced Jul 16, 2024
Closed
Merged
@apoelstra
Copy link
Member

I wouldn't mind adding Default which returns the zero element but Ord definitely does not make sense for a GF32 element.

@optout21 optout21 changed the title Add Default and Ord trait to Fe32 Add Default trait to Fe32 Jul 16, 2024
@optout21
Copy link
Contributor Author

Updated description, as Ord trait was dropped.

@optout21 optout21 mentioned this issue Jul 19, 2024
Closed
3 tasks
apoelstra added a commit that referenced this issue Jul 31, 2024
@apoelstra
Merge #184: Add Default trait to Fe32 (derived)
49ddb1c 
704e891 Add Default trait to Fe32 (derived) (optout)

Pull request description:

  See #187 .

  Add derived `Default` trait to `Fe32`, ~~and `ZERO` constant~~.
  Default is trivial to add, but it is useful in some cases.

ACKs for top commit:
  tcharding:
    ACK 704e891
  apoelstra:
    ACK 704e891
  clarkmoody:
    ACK 704e891

Tree-SHA512: 2d6385f92974d893c2e79d68712e85354ada8faa53ed30896e53f240a2e0272bc700c7559b531efeff22550ef6d58fc2ca5e4ed32df4ea4decd97c2b4f18d90f
@tcharding
Copy link
Member

Closed by #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apoelstra @tcharding @optout21