Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #33

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix CI #33

merged 2 commits into from
Oct 25, 2023

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Oct 25, 2023

Fix CI by doing:

  • Pin memchr
  • Fix new clippy version warnings (remove unnecessary vec)

This was referenced Oct 25, 2023
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5334b21

contrib/test.sh Outdated Show resolved Hide resolved
Recently `memchr` started using edition 2021 in a patch release, this
breaks our MSRV build. Pin it.
Clippy emits:

 error: useless use of `vec!`

As suggested, remove the macro call. Rename the variable to `bytes`
instead of `v` to better suit the new array type.
@tcharding
Copy link
Member Author

Fixed the memchr typo in the docs, no other changes.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cce5574

@apoelstra apoelstra merged commit d61f5f9 into rust-bitcoin:master Oct 25, 2023
9 checks passed
@tcharding tcharding deleted the 10-26-fix-ci branch October 26, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants