Add nth unit tests #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
10-25-nth
branch
2 times, most recently
from
763bece to
38cad31
Compare
|
CI is broken because of another MSRV break in our sole dependency. |
|
Thanks for checking the ci fail for me, I added a pinning patch at the front of the PR. No other changes. |
Clippy emits: error: useless use of `vec!` As suggested, remove the macro call. Rename the variable to `bytes` instead of `v` to better suit the new array type.
Add some unit tests to prove that the default implementation of `nth` works correctly for `HexToBytesIter` and `BytesToHexIter`. Resolve: rust-bitcoin#14
|
Needs #33 to get past CI. |
apoelstra
approved these changes
Oct 25, 2023
|
This PR is total rubbish because it misses the whole point that implementing a custom |
|
Yes, but surely there's still value in testing that the perf improvements don't break the functionality? |
|
True, I might have been a bit trigger happy with the close button. We definitely should put unit tests in the perf PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some unit tests to prove that the default implementation of
nthworks correctly forHexToBytesIterandBytesToHexIter.Resolve: #14