Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parse instead of deserialize_hex for hash types #11

Closed
tcharding opened this issue Nov 27, 2024 · 4 comments · Fixed by #15
Closed

Use parse instead of deserialize_hex for hash types #11

tcharding opened this issue Nov 27, 2024 · 4 comments · Fixed by #15
Labels
good first issue Good for newcomers

Comments

@tcharding
Copy link
Member

One can deserialize a hex string into a Txid using either encode::deserialize_hex() or parse::<Txid>(). Use parse everywhere in favour of using standard traits over custom functions.
@tcharding tcharding changed the title Use pares instead of deserialize_hex for hash types Use parse instead of deserialize_hex for hash types Nov 27, 2024
@tcharding tcharding added the good first issue Good for newcomers label Nov 28, 2024
@fedemagnani
Copy link
Contributor

Hi can I take this?

@fedemagnani fedemagnani mentioned this issue Dec 2, 2024
Merged
@tcharding
Copy link
Member Author

Sure thing, go for it! Thanks

@fedemagnani
Copy link
Contributor

@tcharding hey, I opened a pr. Let me know if is there anything you would like to be changed!

@tcharding
Copy link
Member Author

Top effort, thanks man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use parse::<Txid>() in place of encode::deserialize_hex() fedemagnani/corepc
2 participants
@tcharding @fedemagnani