Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many generated files are not persisted in git #9

Open
rusefillc opened this issue Apr 2, 2024 · 6 comments
Open

Many generated files are not persisted in git #9

rusefillc opened this issue Apr 2, 2024 · 6 comments

Comments

@rusefillc
Copy link
Contributor

S2R:
git pull, no local changes

./compile_firmware.sh
git status

expected behavior: maybe a couple of local files have changed in light of daily automation generating stuff

actual result: too many generated files have fresh content

@rusefillc
Copy link
Contributor Author

@chuckwagoncomputing can you help?

@chuckwagoncomputing
Copy link
Member

I just tried this and I couldn't reproduce it. Can you post git status?

@rusefillc
Copy link
Contributor Author

rusefi@DESKTOP-57S88S8:~/fw-custom-paralela$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
rusefi@DESKTOP-57S88S8:~/fw-custom-paralela$

@rusefillc
Copy link
Contributor Author

nothing to commit, working tree clean
rusefi@DESKTOP-57S88S8:~/fw-custom-paralela$ ./compile_firmware.sh
[META] Reading meta env from ./../../../meta-info.env
[META] PROJECT_BOARD=
[META] PROJECT_CPU=
[META] POST_BUILD_SCRIPT=
[META] BOARD_DIR=./../../..
[META] USE_OPENBLT=
PROJECT_BOARD: paralela
BOARD_DIR:     ././../../..
PROJECT_CPU:   ARCH_STM32F4
SHORT_BOARD_NAME: paralela
CPU_HWLAYER:   ports/stm32/stm32f4

@rusefillc
Copy link
Contributor Author

rusefillc commented Apr 4, 2024

@chuckwagoncomputing I guess I am unable to reproduce the problem :(

   text    data     bss     dec     hex filename
 654166    1468  190648  846282   ce9ca build/rusefi.elf
 20 .ram4         0000ee70  10000000  080a011c  000c0000  2**3

Done
rusefi@DESKTOP-57S88S8:~/fw-custom-paralela$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)
        modified:   ext/rusefi (modified content, untracked content)

no changes added to commit (use "git add" and/or "git commit -a")
rusefi@DESKTOP-57S88S8:~/fw-custom-paralela$
no changes added to commit (use "git add" and/or "git commit -a")
rusefi@DESKTOP-57S88S8:~/fw-custom-paralela$ cd ext/rusefi/
rusefi@DESKTOP-57S88S8:~/fw-custom-paralela/ext/rusefi$ git status
HEAD detached at 2cea463027
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   firmware/hw_layer/mass_storage/ramdisk_image.h
        modified:   firmware/hw_layer/mass_storage/ramdisk_image_compressed.h
        modified:   java_console/models/src/main/java/com/rusefi/config/generated/Fields.java

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        firmware/controllers/generated/engine_configuration_generated_structures_paralela.h
        firmware/controllers/generated/rusefi_generated_paralela.h
        firmware/controllers/generated/signature_paralela.h
        firmware/tunerstudio/generated/rusefi_paralela.ini

no changes added to commit (use "git add" and/or "git commit -a")
rusefi@DESKTOP-57S88S8:~/fw-custom-paralela/ext/rusefi$

@chuckwagoncomputing
Copy link
Member

Is it possible that you pulled before the workflow had finished running, and thus hadn't pushed the configs yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants