From f441fc9767d75ad893277a86cd846e7bfbb33a77 Mon Sep 17 00:00:00 2001 From: Hayato Kiwata <44946173+haytok@users.noreply.github.com> Date: Wed, 29 May 2024 01:49:13 +0900 Subject: [PATCH] fix: Remove unnecessary error handling (#961) Inside the ConfigureDefaultLimaYaml() function, there is a process to write to the config file as follows: ``` if err := afero.WriteFile(lca.fs, lca.limaDefaultConfigPath, limaCfgBytes, 0o600); err != nil { return fmt.Errorf("failed to write to the lima config file: %w", err) } if err != nil { return fmt.Errorf("unable to apply override config: %w", err) } ``` The current implementation has two error checks to determine if the file can be written. The err object in the second part is guaranteed to be nil due to the previous if statement. Therefore, this fix removes the unnecessary second error check. Issue #, if available: N/A *Description of changes:* The details are described in this commit message. *Testing done:* N/A - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Hayato Kiwata --- pkg/config/lima_config_applier.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkg/config/lima_config_applier.go b/pkg/config/lima_config_applier.go index 7628d7666..02e7715fa 100644 --- a/pkg/config/lima_config_applier.go +++ b/pkg/config/lima_config_applier.go @@ -142,10 +142,6 @@ func (lca *limaConfigApplier) ConfigureDefaultLimaYaml() error { return fmt.Errorf("failed to write to the lima config file: %w", err) } - if err != nil { - return fmt.Errorf("unable to apply override config: %w", err) - } - return nil }