From e2221310e1725b3a6072abe12e72f01859ce3320 Mon Sep 17 00:00:00 2001 From: Gavin Inglis <43075615+ginglis13@users.noreply.github.com> Date: Tue, 12 Sep 2023 09:19:54 -0700 Subject: [PATCH] fix(Makefile): use POSIX tar syntax for stdin (#529) Issue #, if available: *Description of changes:* In x mode, all POSIX-compliant versions of tar require -f to read the input archive from somewhere other than the default. Some machines (e.g. Windows) may not have the GNU version of tar installed. *Testing done:* - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index db4f476ab..44f67dc1d 100644 --- a/Makefile +++ b/Makefile @@ -68,7 +68,7 @@ finch-core: "$(MAKE)" mkdir -p _output - cd deps/finch-core/_output && tar c * | tar Cvx $(OUTDIR) + cd deps/finch-core/_output && tar -cf - * | tar -xvf - -C $(OUTDIR) rm -rf $(OUTDIR)/lima-template .PHONY: local-core @@ -80,8 +80,8 @@ local-core: "$(MAKE)" lima lima-socket-vmnet mkdir -p _output - cd deps/finch-core/_output && tar c * | tar Cvx $(OUTDIR) - cd deps/finch-core/src/lima/_output && tar c * | tar Cvx $(OUTDIR)/lima + cd deps/finch-core/_output && tar -cf - * | tar -xvf - -C $(OUTDIR) + cd deps/finch-core/src/lima/_output && tar -cf - * | tar -xvf - -C $(OUTDIR)/lima rm -rf $(OUTDIR)/lima-template .PHONY: lima-and-qemu @@ -121,7 +121,7 @@ config.yaml: .PHONY: copy copy: mkdir -p $(DEST) - (cd _output && tar c * | tar Cvx $(DEST) ) + (cd _output && tar -cf - * | tar -xvf - -C $(DEST) ) .PHONY: install install: copy