From f140aa39574ac20c4a1bff6812fa5c8b9fab4985 Mon Sep 17 00:00:00 2001
From: Justin <pendo324@users.noreply.github.com>
Date: Wed, 3 Jan 2024 13:32:42 -0500
Subject: [PATCH] ci: move from manifest to config file (#746)

Issue #, if available: release-please action not triggering as expected,
see
[errors](https://github.com/runfinch/finch/actions/runs/7292396775/job/20104474662)
and previous PR (https://github.com/runfinch/finch/pull/738)

*Description of changes:*
- I re-read the release-please-action
[documentation](https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#advanced-release-configuration),
and I think I put the config in the wrong file in my previous PR.
- Followed the instructions
[here](https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md)
to create a manifest release since that seems to be what release-please
requires when using a config file on v4
- Moved release-type to the config file instead of the yaml directly
because the action [seems to
branch](https://github.com/google-github-actions/release-please-action/blob/cc61a07e2da466bebbc19b3a7dd01d6aecb20d1e/src/index.ts#L83)
its behavior depending on if that's present or not

*Testing done:*
- Tested on my fork, but its hard to replicate the upstream perfectly


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
---
 .github/workflows/release-please.yaml |  2 -
 .release-please-manifest.json         | 26 +-----------
 release-please-config.json            | 59 +++++++++++++++++++++++++++
 3 files changed, 60 insertions(+), 27 deletions(-)
 create mode 100644 release-please-config.json

diff --git a/.github/workflows/release-please.yaml b/.github/workflows/release-please.yaml
index 7e27a6266..310a37a1d 100644
--- a/.github/workflows/release-please.yaml
+++ b/.github/workflows/release-please.yaml
@@ -9,5 +9,3 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: google-github-actions/release-please-action@v4
-        with:
-          release-type: go
diff --git a/.release-please-manifest.json b/.release-please-manifest.json
index bb07e0f56..f215a3dae 100644
--- a/.release-please-manifest.json
+++ b/.release-please-manifest.json
@@ -1,27 +1,3 @@
 {
-    ".": {
-        "package-name": "finch",
-        "changelog-sections": [
-            {
-                "type": "feat",
-                "section": "Features",
-                "hidden": false
-            },
-            {
-                "type": "fix",
-                "section": "Bug Fixes",
-                "hidden": false
-            },
-            {
-                "type": "exp",
-                "section": "Experimental",
-                "hidden": false
-            },
-            {
-                "type": "build",
-                "section": "Build System or External Dependencies",
-                "hidden": false
-            }
-        ]
-    }
+    ".": "1.0.1"
 }
diff --git a/release-please-config.json b/release-please-config.json
new file mode 100644
index 000000000..4c4ff1a90
--- /dev/null
+++ b/release-please-config.json
@@ -0,0 +1,59 @@
+{
+    "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
+    "release-type": "go",
+    "changelog-sections": [
+        {
+            "type": "build",
+            "section": "Build System or External Dependencies",
+            "hidden": false
+        },
+        {
+            "type": "exp",
+            "section": "Experimental",
+            "hidden": false
+        },
+        {
+            "type": "feat",
+            "section": "Features",
+            "hidden": false
+        },
+        {
+            "type": "fix",
+            "section": "Bug Fixes",
+            "hidden": false
+        },
+        {
+            "type": "revert",
+            "section": "Reverts",
+            "hidden": false
+        },
+        {
+            "type": "chore",
+            "section": "Miscellaneous Chores",
+            "hidden": true
+        },
+        {
+            "type": "docs",
+            "section": "Documentation",
+            "hidden": true
+        },
+        {
+            "type": "refactor",
+            "section": "Code Refactoring",
+            "hidden": true
+        },
+        {
+            "type": "test",
+            "section": "Tests",
+            "hidden": true
+        },
+        {
+            "type": "ci",
+            "section": "Continuous Integration",
+            "hidden": true
+        }
+    ],
+    "packages": {
+        ".": {}
+    }
+}