Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add static binaries to release #63

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

coderbirju
Copy link
Contributor

@coderbirju coderbirju commented Sep 21, 2024

Issue #, if available:

Description of changes:

Testing done:

  • verified o/p of finch daemon binaries from fork release
  • dynamic
    $ ldd ./finch-daemon linux-vdso.so.1 (0x00007ffc112ba000) libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x0000778e82c00000) /lib64/ld-linux-x86-64.so.2 (0x0000778e82e43000)

$ file ./finc-daemon
./finch-daemon: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=3db17231b58a26bfc842a2f4101034c909cee7e8, for GNU/Linux 3.2.0, with debug_info, not stripped

  • static
    $ ldd ./finch-daemon not a dynamic executable

$ file ./finc-daemon
./finch-daemon: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), statically linked, BuildID[sha1]=24763e08999dd8508011f063060edc54e00b8448, for GNU/Linux 3.2.0, with debug_info, not stripped

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju coderbirju force-pushed the make-binaries-static branch 2 times, most recently from 6057cc4 to 16c9c5c Compare September 21, 2024 19:07
@coderbirju coderbirju changed the title fix: Add static binaries to release fix: Add static binaries to release [WIP] Sep 23, 2024
cezar-r
cezar-r previously approved these changes Sep 23, 2024
@coderbirju coderbirju force-pushed the make-binaries-static branch 6 times, most recently from dbf3fb8 to fcdb9d0 Compare October 2, 2024 22:27
@coderbirju coderbirju closed this Oct 2, 2024
@coderbirju coderbirju force-pushed the make-binaries-static branch from fcdb9d0 to a97a89a Compare October 2, 2024 22:28
@coderbirju coderbirju reopened this Oct 2, 2024
@coderbirju coderbirju force-pushed the make-binaries-static branch from 1f0c2e5 to 06276fa Compare October 2, 2024 22:48
@coderbirju coderbirju changed the title fix: Add static binaries to release [WIP] fix: Add static binaries to release Oct 2, 2024
.github/workflows/release-automation.yaml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@coderbirju coderbirju force-pushed the make-binaries-static branch from 06276fa to 5887d3b Compare October 13, 2024 04:04
@coderbirju coderbirju force-pushed the make-binaries-static branch 5 times, most recently from 852ca42 to e698209 Compare October 24, 2024 18:42
henry118
henry118 previously approved these changes Oct 25, 2024
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
@coderbirju coderbirju force-pushed the make-binaries-static branch from 6e95440 to 723e435 Compare October 30, 2024 21:01
Signed-off-by: Arjun Raja Yogidas <[email protected]>
@coderbirju coderbirju force-pushed the make-binaries-static branch from 723e435 to 233d424 Compare October 30, 2024 21:02
@Shubhranshu153 Shubhranshu153 merged commit 57a0c44 into runfinch:main Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants