COMMENT_ARGS escaping in custom run line

[mikecook]

COMMENT_ARGS is escaping every single character for my attempt at a targeted plan: \-\t\a\r\g\e\t\=\f\a\k\e\.\r\e\s\o\u\r\c\e when using a custom run line (https://www.runatlantis.io/docs/custom-workflows.html#custom-init-plan-apply-commands) that appends $COMMENT_ARGS to the end of the terraform command.

The default plan command in the context gets the unescaped commentFlags:

atlantis/server/events/project_command_context_builder.go

Line 120 in 90e92e3

cb.CommentBuilder.BuildPlanComment(prjCfg.RepoRelDir, prjCfg.Workspace, prjCfg.Name, commentFlags),

But the COMMENT_ARGS uses escapedCommentArgs, which runs func escapeArgs against commentFlags

atlantis/server/events/project_command_context_builder.go

Lines 116 to 125 in 90e92e3

	projectCmdContext := newProjectCommandContext(
	ctx,
	cmdName,
	cb.CommentBuilder.BuildApplyComment(prjCfg.RepoRelDir, prjCfg.Workspace, prjCfg.Name, prjCfg.AutoMergeDisabled),
	cb.CommentBuilder.BuildPlanComment(prjCfg.RepoRelDir, prjCfg.Workspace, prjCfg.Name, commentFlags),
	cb.CommentBuilder.BuildVersionComment(prjCfg.RepoRelDir, prjCfg.Workspace, prjCfg.Name),
	prjCfg,
	steps,
	prjCfg.PolicySets,
	escapeArgs(commentFlags),

to create escapedCommentArgs

atlantis/server/events/project_command_context_builder.go

Line 211 in 90e92e3

escapedCommentArgs []string,

and the func escapeArgs

atlantis/server/events/project_command_context_builder.go

Lines 271 to 281 in 90e92e3

	func escapeArgs(args []string) []string {
	var escaped []string
	for _, arg := range args {
	var escapedArg string
	for i := range arg {
	escapedArg += "\\" + string(arg[i])
	}
	escaped = append(escaped, escapedArg)
	}
	return escaped
	}

is run for every single character whether it would need escaping or not:

atlantis/server/events/project_command_context_builder.go

Lines 275 to 277 in 90e92e3

	for i := range arg {
	escapedArg += "\\" + string(arg[i])
	}

but then the tests ignore the func escapeArgs and repeatedly pass contexts with unescaped text as if it were escaped.

atlantis/server/core/runtime/run_step_runner_test.go

Line 140 in 90e92e3

EscapedCommentArgs: []string{"-target=resource1", "-target=resource2"},

atlantis/server/core/runtime/plan_type_step_runner_delegate_test.go

Line 53 in 90e92e3

EscapedCommentArgs: []string{"comment", "args"},

atlantis/server/core/runtime/plan_type_step_runner_delegate_test.go

Line 111 in 90e92e3

EscapedCommentArgs: []string{"comment", "args"},

atlantis/server/core/runtime/plan_type_step_runner_delegate_test.go

Line 140 in 90e92e3

EscapedCommentArgs: []string{"comment", "args"},

atlantis/server/core/runtime/apply_step_runner_test.go

Line 217 in 22dec19

EscapedCommentArgs: c.commentFlags,

atlantis/server/core/runtime/policy_check_step_runner_test.go

Line 27 in 90e92e3

EscapedCommentArgs: []string{"comment", "args"},

Is there something I'm missing or some flag to use non-escaped context?