Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow module devs and users to ignore specific conflicts #33

Open
3 of 4 tasks
ruipin opened this issue May 4, 2021 · 1 comment
Open
3 of 4 tasks

Allow module devs and users to ignore specific conflicts #33

ruipin opened this issue May 4, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ruipin
Copy link
Owner

ruipin commented May 4, 2021

Right now, libWrapper only has global toggles to disable all notifications related to detected conflicts.

Sometimes, conflicts are expected and known by a module dev or the user, and they do not want to see the notifications for them. However, disabling the notifications runs the risk of the user not being told of new conflicts after e.g. updating various modules.

  • The backend needs to be updated to support ignoring specific conflicts.

  • There should still be a toggle in the "Conflicts" pane to show all conflicts detected, even those that were ignored. This would allow to debug issues where ignores are too broad.

  • There should be an API that allows module devs to choose conflicts that the user should not be notified of.

  • There should be a new config pane that allows the user to choose specific notifications they do not want to see again.

@ruipin ruipin added the enhancement New feature or request label May 4, 2021
@ruipin ruipin changed the title Allow user to ignore specific warnings/errors. Allow module devs and users to ignore specific warnings/errors. Jun 9, 2021
@ruipin ruipin changed the title Allow module devs and users to ignore specific warnings/errors. Allow module devs and users to ignore specific conflicts Jun 9, 2021
@ruipin
Copy link
Owner Author

ruipin commented Jun 18, 2021

v1.7.1.0 implements the backend for this, as well as the libWrapper.ignore_conflicts API for module developers to use.

A UI to expose this functionality to users directly will need to be added at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant