Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write an UI test to make sure matrix and tree always displayed together by given valid input #49

Open
namvdo opened this issue Nov 13, 2024 · 2 comments
Assignees

Comments

@namvdo
Copy link
Collaborator

namvdo commented Nov 13, 2024

As we work on the GUI improvement, we need to make sure that our new changes will not cause breaks in our major UI components, such as search input, NCD matrix, and the Quartet search tree.

For the very first UI test, when the input is valid, we need to make sure:

  • The NCD matrix correctly shows
  • The Quartet tree is correctly shown
  • As the input changes, the UI components need to be updated accordingly.
@Sonnpm197
Copy link
Collaborator

Sonnpm197 commented Nov 14, 2024

Opening issue from pmndrs/drei#2198 (comment)
Will continue after is one is closed

Downgrade to 115 doesn't work

@namvdo
Copy link
Collaborator Author

namvdo commented Nov 25, 2024

We've merged a PR related to this issue: #68, but the discussion remains open.

@namvdo namvdo closed this as completed Nov 25, 2024
@namvdo namvdo reopened this Nov 25, 2024
@Sonnpm197 Sonnpm197 assigned namvdo and unassigned Sonnpm197 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants