From af66e0406208a4279c2b90881456bbbc9bb9444a Mon Sep 17 00:00:00 2001 From: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Date: Wed, 24 Jan 2024 01:52:11 +0530 Subject: [PATCH 1/3] feat: add support in fb pixel for advertiser_tracking_enabled --- .../facebook_pixel/data/FBPIXELCommonConfig.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/v0/destinations/facebook_pixel/data/FBPIXELCommonConfig.json b/src/v0/destinations/facebook_pixel/data/FBPIXELCommonConfig.json index 11a81a20ab..1ba6c4c82f 100644 --- a/src/v0/destinations/facebook_pixel/data/FBPIXELCommonConfig.json +++ b/src/v0/destinations/facebook_pixel/data/FBPIXELCommonConfig.json @@ -33,5 +33,10 @@ "context.traits.action_source", "properties.action_source" ] + }, + { + "destKey": "advertiser_tracking_enabled", + "sourceKeys": "context.device.adTrackingEnabled", + "required": false } ] From 979e8b8f7993e78b7a1872b012892807b4b28873 Mon Sep 17 00:00:00 2001 From: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Date: Thu, 6 Jun 2024 04:55:38 +0530 Subject: [PATCH 2/3] chore: add corresponding router test --- .../facebook_pixel/router/data.ts | 109 ++++++++++++++++++ 1 file changed, 109 insertions(+) diff --git a/test/integrations/destinations/facebook_pixel/router/data.ts b/test/integrations/destinations/facebook_pixel/router/data.ts index 4bd9914768..bd607288d4 100644 --- a/test/integrations/destinations/facebook_pixel/router/data.ts +++ b/test/integrations/destinations/facebook_pixel/router/data.ts @@ -201,4 +201,113 @@ export const data = [ }, }, }, + { + name: 'facebook_pixel', + description: 'Test 1', + feature: 'router', + module: 'destination', + version: 'v0', + input: { + request: { + body: { + input: [ + { + message: { + anonymousId: 'c82cbdff-e5be-4009-ac78-cdeea09ab4b1', + destination_props: { Fb: { app_id: 'RudderFbApp' } }, + context: { + device: { + id: 'df16bffa-5c3d-4fbb-9bce-3bab098129a7R', + manufacturer: 'Xiaomi', + model: 'Redmi 6', + name: 'xiaomi', + adTrackingEnabled: true, + }, + network: { carrier: 'Banglalink' }, + os: { name: 'android', version: '8.1.0' }, + screen: { height: '100', density: 50 }, + traits: { + email: 'abc@gmail.com', + anonymousId: 'c82cbdff-e5be-4009-ac78-cdeea09ab4b1', + }, + }, + event: 'spin_result', + integrations: { All: true }, + message_id: 'a80f82be-9bdc-4a9f-b2a5-15621ee41df8', + properties: { revenue: 400, additional_bet_index: 0 }, + timestamp: '2023-10-14T15:46:51.693229+05:30', + type: 'track', + }, + metadata: { jobId: 1, userId: 'u1' }, + destination: { + Config: { + limitedDataUsage: true, + blacklistPiiProperties: [{ blacklistPiiProperties: '', blacklistPiiHash: false }], + removeExternalId: true, + accessToken: '09876', + pixelId: 'dummyPixelId', + eventsToEvents: [{ from: '', to: '' }], + eventCustomProperties: [{ eventCustomProperties: '' }], + valueFieldIdentifier: '', + advancedMapping: false, + whitelistPiiProperties: [{ whitelistPiiProperties: '' }], + }, + Enabled: true, + }, + }, + ], + destType: 'facebook_pixel', + }, + method: 'POST', + }, + }, + output: { + response: { + status: 200, + body: { + output: [ + { + batchedRequest: { + version: '1', + type: 'REST', + method: 'POST', + endpoint: 'https://graph.facebook.com/v18.0/dummyPixelId/events?access_token=09876', + headers: {}, + params: {}, + body: { + JSON: {}, + XML: {}, + JSON_ARRAY: {}, + FORM: { + data: [ + '{"user_data":{"em":"48ddb93f0b30c475423fe177832912c5bcdce3cc72872f8051627967ef278e08"},"event_name":"spin_result","event_time":1697278611,"advertiser_tracking_enabled":true,"action_source":"other","custom_data":{"additional_bet_index":0,"value":400}}', + ], + }, + }, + files: {}, + }, + metadata: [{ jobId: 1, userId: 'u1' }], + batched: false, + statusCode: 200, + destination: { + Config: { + limitedDataUsage: true, + blacklistPiiProperties: [{ blacklistPiiProperties: '', blacklistPiiHash: false }], + removeExternalId: true, + accessToken: '09876', + pixelId: 'dummyPixelId', + eventsToEvents: [{ from: '', to: '' }], + eventCustomProperties: [{ eventCustomProperties: '' }], + valueFieldIdentifier: '', + advancedMapping: false, + whitelistPiiProperties: [{ whitelistPiiProperties: '' }], + }, + Enabled: true, + }, + }, + ], + }, + }, + }, + }, ].map((d) => ({ ...d, mockFns })); From fe8fa3bc9b4fc6c94ab05e560b44c940d108d049 Mon Sep 17 00:00:00 2001 From: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Date: Fri, 14 Jun 2024 10:52:08 +0530 Subject: [PATCH 3/3] chore: update router tests descriptions in fb pixel --- .../integrations/destinations/facebook_pixel/router/data.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/integrations/destinations/facebook_pixel/router/data.ts b/test/integrations/destinations/facebook_pixel/router/data.ts index bd607288d4..1d3b35b42a 100644 --- a/test/integrations/destinations/facebook_pixel/router/data.ts +++ b/test/integrations/destinations/facebook_pixel/router/data.ts @@ -8,7 +8,8 @@ export const mockFns = (_) => { export const data = [ { name: 'facebook_pixel', - description: 'Test 0', + description: + 'Test 0: General batch request with two events, one track and one identify event with advancedMapping set to false and true respectively', feature: 'router', module: 'destination', version: 'v0', @@ -203,7 +204,8 @@ export const data = [ }, { name: 'facebook_pixel', - description: 'Test 1', + description: + 'Test 1 : adTrackingEnabled is passed in context, advertiser_tracking_enabled set to true', feature: 'router', module: 'destination', version: 'v0',