From 8eb4c4e9b8daebbaeb1d12ff0c17915fe19c2b50 Mon Sep 17 00:00:00 2001
From: Anant Jain <62471433+anantjain45823@users.noreply.github.com>
Date: Mon, 8 Apr 2024 17:10:16 +0530
Subject: [PATCH] fix: shopify: send 500 for identifier call in case of failure
 (#3235)

Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com>
---
 src/util/redis/testData/shopify_source.json |  7 ++-----
 src/v0/sources/shopify/transform.js         | 12 ++++--------
 2 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/src/util/redis/testData/shopify_source.json b/src/util/redis/testData/shopify_source.json
index 04b80b8fc9..2120475baf 100644
--- a/src/util/redis/testData/shopify_source.json
+++ b/src/util/redis/testData/shopify_source.json
@@ -65,11 +65,8 @@
       }
     },
     "output": {
-      "outputToSource": {
-        "body": "T0s=",
-        "contentType": "text/plain"
-      },
-      "statusCode": 200
+      "error": "Error: Error setting value in Redis due Error: Connection is Closed",
+      "statusCode": 500
     }
   },
   {
diff --git a/src/v0/sources/shopify/transform.js b/src/v0/sources/shopify/transform.js
index 93e3ed0c72..b6d2a4c6cf 100644
--- a/src/v0/sources/shopify/transform.js
+++ b/src/v0/sources/shopify/transform.js
@@ -1,6 +1,7 @@
 /* eslint-disable @typescript-eslint/naming-convention */
 const lodash = require('lodash');
 const get = require('get-value');
+const { RedisError } = require('@rudderstack/integrations-lib');
 const stats = require('../../../util/stats');
 const {
   getShopifyTopic,
@@ -249,16 +250,11 @@ const processIdentifierEvent = async (event, metricMetadata) => {
         source: metricMetadata.source,
         writeKey: metricMetadata.writeKey,
       });
+      // returning 500 as status code in case of redis failure
+      throw new RedisError(`${e}`, 500);
     }
   }
-  const result = {
-    outputToSource: {
-      body: Buffer.from('OK').toString('base64'),
-      contentType: 'text/plain',
-    },
-    statusCode: 200,
-  };
-  return result;
+  return NO_OPERATION_SUCCESS;
 };
 const process = async (event) => {
   const metricMetadata = {