From 750fe8f73b153601e3c503b611d617236efb39a6 Mon Sep 17 00:00:00 2001
From: Gauravudia <60897972+Gauravudia@users.noreply.github.com>
Date: Mon, 18 Mar 2024 18:18:58 +0530
Subject: [PATCH] chore: add event validation for movable ink destination
 (#3190)

chore: add validation for movable ink destination
---
 .../movable_ink/procWorkflow.yaml             |  1 +
 src/cdk/v2/destinations/movable_ink/utils.js  | 21 +++++
 .../movable_ink/processor/validation.ts       | 86 +++++++++++++++++++
 3 files changed, 108 insertions(+)
 create mode 100644 src/cdk/v2/destinations/movable_ink/utils.js

diff --git a/src/cdk/v2/destinations/movable_ink/procWorkflow.yaml b/src/cdk/v2/destinations/movable_ink/procWorkflow.yaml
index 25270058c5..43dbb3cbce 100644
--- a/src/cdk/v2/destinations/movable_ink/procWorkflow.yaml
+++ b/src/cdk/v2/destinations/movable_ink/procWorkflow.yaml
@@ -33,6 +33,7 @@ steps:
       );
 
       $.assert(userId ?? email ?? .message.anonymousId, "Either one of userId or email or anonymousId is required. Aborting");
+      $.validateEventPayload(.message);
 
   - name: preparePayload
     description: Prepare payload for identify and track. This payload schema needs to be configured in the Movable Ink dashboard. Movable Ink will discard any additional fields from the input payload.
diff --git a/src/cdk/v2/destinations/movable_ink/utils.js b/src/cdk/v2/destinations/movable_ink/utils.js
new file mode 100644
index 0000000000..04d7046b1a
--- /dev/null
+++ b/src/cdk/v2/destinations/movable_ink/utils.js
@@ -0,0 +1,21 @@
+const { InstrumentationError } = require('@rudderstack/integrations-lib');
+
+const validateEventPayload = (message) => {
+  const { event } = message;
+  const { properties } = message;
+  if (event === 'Products Searched' && !properties?.query) {
+    throw new InstrumentationError("Missing 'query' property in properties. Aborting");
+  }
+
+  if (
+    (event === 'Product Added' ||
+      event === 'Product Removed' ||
+      event === 'Product Viewed' ||
+      event === 'Category Viewed') &&
+    !properties?.product_id
+  ) {
+    throw new InstrumentationError("Missing 'product_id' property in properties. Aborting");
+  }
+};
+
+module.exports = { validateEventPayload };
diff --git a/test/integrations/destinations/movable_ink/processor/validation.ts b/test/integrations/destinations/movable_ink/processor/validation.ts
index f9f6c6a927..ab6b123eb7 100644
--- a/test/integrations/destinations/movable_ink/processor/validation.ts
+++ b/test/integrations/destinations/movable_ink/processor/validation.ts
@@ -128,4 +128,90 @@ export const validation: ProcessorTestData[] = [
       },
     },
   },
+  {
+    id: 'MovableInk-validation-test-4',
+    name: destType,
+    description: "Products Searched event - Missing 'query' property",
+    scenario: 'Framework',
+    successCriteria: 'Instrumentation Error',
+    feature: 'processor',
+    module: 'destination',
+    version: 'v0',
+    input: {
+      request: {
+        body: [
+          {
+            destination,
+            message: {
+              type: 'track',
+              userId: 'user123',
+              integrations: {
+                All: true,
+              },
+              event: 'Products Searched',
+              originalTimestamp: '2024-03-04T15:32:56.409Z',
+            },
+            metadata: generateMetadata(1),
+          },
+        ],
+      },
+    },
+    output: {
+      response: {
+        status: 200,
+        body: [
+          {
+            error:
+              "Missing 'query' property in properties. Aborting: Workflow: procWorkflow, Step: validateInput, ChildStep: undefined, OriginalError: Missing 'query' property in properties. Aborting",
+            metadata: generateMetadata(1),
+            statTags: processorInstrumentationErrorStatTags,
+            statusCode: 400,
+          },
+        ],
+      },
+    },
+  },
+  {
+    id: 'MovableInk-validation-test-5',
+    name: destType,
+    description: "Products Added event - Missing 'product_id' property",
+    scenario: 'Framework',
+    successCriteria: 'Instrumentation Error',
+    feature: 'processor',
+    module: 'destination',
+    version: 'v0',
+    input: {
+      request: {
+        body: [
+          {
+            destination,
+            message: {
+              type: 'track',
+              userId: 'user123',
+              integrations: {
+                All: true,
+              },
+              event: 'Product Added',
+              originalTimestamp: '2024-03-04T15:32:56.409Z',
+            },
+            metadata: generateMetadata(1),
+          },
+        ],
+      },
+    },
+    output: {
+      response: {
+        status: 200,
+        body: [
+          {
+            error:
+              "Missing 'product_id' property in properties. Aborting: Workflow: procWorkflow, Step: validateInput, ChildStep: undefined, OriginalError: Missing 'product_id' property in properties. Aborting",
+            metadata: generateMetadata(1),
+            statTags: processorInstrumentationErrorStatTags,
+            statusCode: 400,
+          },
+        ],
+      },
+    },
+  },
 ];