Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concept of Administrator #65

Open
rossfuhrman opened this issue Oct 8, 2017 · 9 comments
Open

Add concept of Administrator #65

rossfuhrman opened this issue Oct 8, 2017 · 9 comments

Comments

@rossfuhrman
Copy link
Collaborator

Several of our other issues reference the idea of Amanda the website Administrator, but we do not have any way of specifying that a given user is an admin.
I'm thinking maybe we can just add an 'admin' flag on the user record so we can determine which users are an admin.

@jacobherrington
Copy link
Contributor

jacobherrington commented Oct 9, 2017

@rossfuhrman Would it make sense to use a gem like cancan and/or rolify here?

@jacobherrington
Copy link
Contributor

That would knock out #66 as well.

@mobjohnson
Copy link
Collaborator

Was looking into this, and I agree with CanCanCan and maybe Rolify too. Ross just implemented 'One Admin to Rule Them All' for orgs, but there will be more than one admin for both Charter and the separate Orgs, and these two get us to there. Not sure that is MVP though. Railscasts include some videos about implementing the original CanCan that I found helpful.

@seanmarcia
Copy link
Member

I'd recommend Pundit :)

@rossfuhrman
Copy link
Collaborator Author

I do think using a gem for authorization is probably a good idea.
I would also be in favor of Pundit (over CanCanCan or Rolify), and that's mainly because I have a bit of experience with Pundit, but none with the others.
As for having multiple admins for a given Organization, I think that will be needed at some point (and like you said @mobjohnson, maybe not for the MVP), but that is a separate issue.

@mobjohnson
Copy link
Collaborator

Pundit looks good!

@jacobherrington
Copy link
Contributor

@mobjohnson are you working on this? I'm happy to if it's up for grabs.

@mobjohnson
Copy link
Collaborator

@jacobherrington no, i am not. go for it!!! :) and thanks for your help. it will be AWESOME.

@cattywampus
Copy link

It looks like this issue was addressed by PR #76, should this be closed or is there still more work that needs to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants