Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol documentation fix #257

Open
thierry-f-78 opened this issue Jun 10, 2023 · 0 comments
Open

Protocol documentation fix #257

thierry-f-78 opened this issue Jun 10, 2023 · 0 comments

Comments

@thierry-f-78
Copy link

Hi,

I'm currently regarding to implement RELP server. I'm processing offer message.

I see in the doc this definition of offer message:

OFFER = LF FEATURENAME ["=" VALUE *("," VALUE)]

But, I do not constat this format in practice with rsyslog client. It seems the LF char is added at the end of message only if it is not the last message.

https://github.com/rsyslog/librelp/blob/master/src/offers.c#L355

I suggest to update doc like this:

OFFERLIST = OFFER *( LF OFFER )
OFFER = FEATURENAME ["=" VALUE *("," VALUE)]

According with doc, at least one offer is mandatory (relp_version) so the ABNF below describe this.

Thierry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant