feat(devnet): makes nonL1 conts start #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
8 times, most recently
from
4b113ef
to
82bbd0f
Compare
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
from
0961f6f
to
71e61c5
Compare
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
2 times, most recently
from
fe23ae8
to
83d2402
Compare
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
from
2a47d8a
to
c57afb0
Compare
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
from
d6cdfec
to
2bae691
Compare
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
from
ee43ddb
to
e6c8d6c
Compare
jurajpiar
commented
Mar 5, 2024
jurajpiar
commented
Mar 5, 2024
jurajpiar
commented
Mar 5, 2024
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
from
a77f057
to
f41833f
Compare
illuque
approved these changes
Mar 5, 2024
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
4 times, most recently
from
71be2ac
to
e9311ae
Compare
jurajpiar
force-pushed
the
rsk/juraj/devnet
branch
from
e9311ae
to
6107a17
Compare
antomor
reviewed
Mar 6, 2024
| @@ -22,7 +18,7 @@ def update_mod(project): | |||
| 'mod', | |||
| 'edit', | |||
| '-replace', | |||
| f'github.com/ethereum/go-ethereum@{GETH_VERSION}=github.com/ethereum-optimism/op-geth@optimism' | |||
| f'github.com/ethereum/go-ethereum=github.com/rsksmart/op-geth@11a70c76751354d7e82def14a56f89f08e59d7b7' # represents tip of github.com/rsksmart/op-geth#rsk/poc-v0 | |||
There was a problem hiding this comment.
Here we use the commit while in other parts we just use the branch. Let's use the same approach if possible
There was a problem hiding this comment.
that's just the thing. it's not possible to use the branch here and that is why we use the commit (see PR description). Although, according to this doc it should be possible. However, when we try it it gives us:
go.mod:216: replace github.com/rsksmart/op-geth: version "rsk/poc-v0" invalid: version "rsk/poc-v0" invalid: disallowed version string
There was a problem hiding this comment.
having said that, I can create a tag and we set it to that?
antomor
reviewed
Mar 6, 2024
| @@ -4,6 +4,7 @@ pragma solidity ^0.8.0; | |||
| /// @notice Chain IDs for the various networks. | |||
| library Chains { | |||
| uint256 internal constant RootstockRegtest = 33; | |||
| uint256 internal constant OPRootstockRegtest = 42069; | |||
There was a problem hiding this comment.
Out of curiosity: is this an arbitrary number?
There was a problem hiding this comment.
I don't know where it came from. I copied it from somewhere, I think Francisco used it first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows developers and CI to run the system with built-in devnet process.
Removes the generated regtest deployments and deploy-config as the devnet process creates the config from a template and the deployment files are not needed to run devnet.
The devnet python script has been heavily modified to accommodate for the differences between rsk and ethereum genesis and block dump.
In addition it uses a our own op-geth as a dependency instead of go-ethereum (
see go.mod), and builds an op-geth and rskj images in the docker compose process.Resolves ROLLUP-521
details
The op-geth PR should be merged first. Once it is, we should change references to it from the PR branch (optimism_genesis) torsk/poc-v0.this one will require to rungit rev-parse rsk/poc-v0once updated.Known issues:
When depositing and withdrawing using the op SDK, the logs-check (get event and compare hash) fails. Although it may be related to some changes in this PR, in order to move on, I've created a bug issue for this instead of fixing it here.