Add page icon #85
Open
Add page icon #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achinwo
commented
Mar 6, 2017
achinwo
commented
- added "shortcut icon" head tag
- added "shortcut icon" head tag
|
update: |
|
Hi Jurosh, I use this site as a reference quite often and wanted to give it an icon for easy bookmarking. The logo in this pull request is hosted on cloudinary here. Feel free to download and incorporate as you see fit. |
jurosh
reviewed
Oct 1, 2017
| @@ -26,6 +26,8 @@ | |||
| SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | |||
| --> | |||
| <title>ECMAScript 6: New Features: Overview and Comparison</title> | |||
| <link rel="icon" type="image/png" href="https://res.cloudinary.com/codeandpush/image/upload/c_scale,w_42/v1488836532/logo_es6_qncxsf.png"/> | |||
| <link rel="shortcut icon" type="image/png" href="https://res.cloudinary.com/codeandpush/image/upload/c_scale,w_42/v1488836532/logo_es6_qncxsf.png"/> | |||
There was a problem hiding this comment.
shortcut keyword is not be required, and ignored by modern browsers. See https://stackoverflow.com/a/13211460/1571491
|
Ah sorry @achinwo , my comment should be only about second icon tag - it's in comment in code now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.