Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DistGitReleaser doesn't work with builder.test = 1 #401

Open
vfreex opened this issue Mar 30, 2021 · 1 comment
Open

DistGitReleaser doesn't work with builder.test = 1 #401

vfreex opened this issue Mar 30, 2021 · 1 comment
Labels
bug Something is clearly a bug effort/medium Can be done in 1-2 days gain/medium Affects multiple users

Comments

@vfreex
Copy link
Contributor

vfreex commented Mar 30, 2021

When running tito release with DistGitReleaser and setting builder.test = 1 in .tito/releasers.conf, tito uploads a source tarball named <name>-<version>-git-<number>.<hash>.tar.gz to DistGit lookaside, but the spec file still implies Source0: %{name}-%{version}.tar.gz. This causes Brew build failures in that source tarball can't be found.

We currently use builder.test = 1 since we don't push commits to the upstream source repo. When running tito release with --test, it works because tito overwrites the Source0: line. But it doesn't work without --test.

This seems to be a bug in tito.

@xsuchy
Copy link
Member

xsuchy commented Mar 30, 2021

This issue is valid, but...
If you had commits which you do not want to send to upstream, you will be better with tito.builder.UpstreamBuilder or tito.distributionbuilder.DistributionBuilder. With this change, you should tagger to 'ReleaseTagger'. See man tito.props for more details.
Test builds were originally meant as developer's snapshots and not really released anywhere.

@FrostyX FrostyX added bug Something is clearly a bug effort/medium Can be done in 1-2 days gain/medium Affects multiple users labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is clearly a bug effort/medium Can be done in 1-2 days gain/medium Affects multiple users
Projects
None yet
Development

No branches or pull requests

3 participants