Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: register user in lock token #15

Open
stanim opened this issue Jan 14, 2020 · 1 comment
Open

Feature request: register user in lock token #15

stanim opened this issue Jan 14, 2020 · 1 comment

Comments

@stanim
Copy link

stanim commented Jan 14, 2020

Would it be possible to register the user in the lock token? Sometimes it is unclear who locked the page.

@rparent
Copy link
Owner

rparent commented Jan 22, 2020

Hello @stanim,

As stated in the app description, the locking mechanism provided by django-lock-tokens is not user based. That's why a lock is not tied to a user. It is supposed to also work for use cases like unauthentified resource locking.

Of course, if you use the for example django admin locking feature, this would make sense to attach a user to the lock token. We could imagine adding a nullable field (e.g. locked_by) with a foreign key to the project's user model, and set it when it is possible.

Unfortunately I don't have much time right now to develop new features for this app, but I would be more than happy to review and discuss a pull-request for this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants