Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make source-path the first priority argument #22

Open
roydukkey opened this issue Jan 15, 2023 · 1 comment
Open

Make source-path the first priority argument #22

roydukkey opened this issue Jan 15, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@roydukkey
Copy link
Owner

Currently, the spec for the CLI is that the first optional, positional argument is backup-path. Then a source-path may optionally be specified before backup-path.

To simplify the API, source-path will be made the first optional, positional argument with the backup-path optionally following source-path.

@roydukkey roydukkey added this to the v3 milestone Jan 15, 2023
@roydukkey roydukkey added the enhancement New feature or request label Jan 15, 2023
@roydukkey roydukkey changed the title Make source-path the first priority argument Make source-path the first priority argument for default command Jan 17, 2023
@roydukkey roydukkey changed the title Make source-path the first priority argument for default command Make source-path the first priority argument Jan 17, 2023
@roydukkey
Copy link
Owner Author

roydukkey commented Jan 17, 2023

The more I'm looking at this the more I'm content with the current API. Why? Because, though the project can be used on any old JSON file, it does imply usage with the package.json file. Therefore, the backup path is really more crucial.

Additionally, should clean-package configuration be cleaned from the source JSON file, it will longer exist at the source-path. In this case, requiring the source-path before specifying the backup-path makes no sense.

I'm gonna leave this open until the rest of the work is complete for v3 and reevaluate at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant