Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for js-promise migration #8

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Update for js-promise migration #8

merged 5 commits into from
Aug 7, 2023

Conversation

thomashoneyman
Copy link
Contributor

This updates the library to make use of js-promise instead of web-promise, including relying on a new fetch-core (another PR is open for that). This cannot be merged until the fetch-core PR merges, and then I can update the dependencies.

bower.json Outdated Show resolved Hide resolved
packages.dhall Outdated Show resolved Hide resolved
@thomashoneyman
Copy link
Contributor Author

Hm — see: nodejs/node#46221

@sigma-andex
Copy link
Member

lgtm, do you want to merge this?

@thomashoneyman
Copy link
Contributor Author

This is failing because of the missing duplex: 'half' argument to requests with bodies (see the linked node issue above). Affects fetch-core, and via fetch-core affects this library as well. Not sure how you would like to handle that (set is as a default when a request has a body?)

@sigma-andex
Copy link
Member

Ok I just read it. So yeah I guess we should set duplex: 'half' as default in fetch-core then

@thomashoneyman
Copy link
Contributor Author

How do you want to do that? On the PureScript side or in the FFI file? It doesn't appear that fetch-core is setting any defaults right now.

@sigma-andex
Copy link
Member

hmm yeah you are right. I don't know, what do you propose?

@thomashoneyman
Copy link
Contributor Author

It isn't required on all bodies — just stream bodies — so I've just added it as another option and set it when necessary.

@thomashoneyman thomashoneyman merged commit 66ab39b into rowtype-yoga:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants