Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Washing html mails #6464

Closed
alexdyukov opened this issue Sep 26, 2018 · 2 comments
Closed

Washing html mails #6464

alexdyukov opened this issue Sep 26, 2018 · 2 comments

Comments

@alexdyukov
Copy link

alexdyukov commented Sep 26, 2018

Hi!

After upgrading from 1.3.5 to 1.3.7 I got issue with washing html emails in web interface. It has remove some words:

$ diff roundcube1.3.*_html.txt
24,37d23
<                            zzz
<                            <span class="values vm2-first_name">zzzzzzzz</span>
<                            zz. zzzzz
<                            <span class="values vm2-email">1</span>
<                            <br class="clear" />
<                            zzzzzzz
<                            <span class="values vm2-phone_1">X-XXX-XXX-XX-XX</span>
<                            <br class="clear" />
<                            zzzzz zzzzzzzz
<                            <span class="values vm2-address">zzzzzzzzz 25  zz 22 zzz 2 zz 1</span>
<                            <br class="clear" />
<                         </td>
<                         <td valign="top" width="50%">
<                            zzz
39d24
<                            zzzzz zzzzzzzz

there is an example mail:
roundcube_example_mail.txt

interface view 1.3.5 compare to 1.3.7:
roundcube1 3 5_html
roundcube1 3 7_html

and "rcmBody" part:
roundcube1.3.5_html.txt
roundcube1.3.7_html.txt

Thank you.

@alexdyukov alexdyukov changed the title washing html mails Washing html mails Sep 26, 2018
@alecpl
Copy link
Member

alecpl commented Sep 27, 2018

I confirm that problem is with handling HTML comments. For this snippet:

<!-- span class="titles">zzz</span -->
<span class="values vm2-first_name" >zzzzzzzz</span>
<!-- span class="titles">zz. zzzzz</span -->
<span class="values vm2-email" >1</span>
<br class="clear" />

output is:

<br class="clear" />

@alecpl alecpl added this to the 1.3.8 milestone Sep 27, 2018
alecpl added a commit that referenced this issue Sep 27, 2018
alecpl added a commit that referenced this issue Sep 27, 2018
@alecpl
Copy link
Member

alecpl commented Sep 27, 2018

Fixed. I have to note that the bahavior in 1.3.5 was also not valid. BTW, the use of comments in that sample message looks really strange and in some cases invalid/confusing.

@alecpl alecpl closed this as completed Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants