Parse all quotas from GETQUOTAROOT #6280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspettl
reviewed
Aug 5, 2018
| while ($line) { | ||
| list($type, $used, $total) = $this->tokenizeResponse($line, 1); | ||
| $quotas = $this->tokenizeResponse($line, 1); | ||
| foreach (array_chunk($quotas, 3) as $quota) { |
There was a problem hiding this comment.
I get the following PHP warning with the current release (1.3.7) in this line:
[04-Aug-2018 15:38:30 UTC] PHP Warning: array_chunk() expects parameter 1 to be array, null given in /var/www/html/program/lib/Roundcube/rcube_imap_generic.php on line 3129
[04-Aug-2018 15:38:30 UTC] PHP Warning: Invalid argument supplied for foreach() in /var/www/html/program/lib/Roundcube/rcube_imap_generic.php on line 3129
My IMAP server (Courier 4.17.2) is not configured for quotas, probably that is the reason. I don't know anything about the IMAP protocol itself, but probably we should do nothing in case of $quotas === NULL?
Edit: sorry, I see we already have the issue #6374 (did not re-check the issue list until just now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoundCube was parsing only the first quota triplet for every Quota Root.
This PR fixes it and in result displays all the enabled quotas.