Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whу _mbox no strip_tags? #6207

Closed
C0nstantin opened this issue Mar 7, 2018 · 3 comments
Closed

whу _mbox no strip_tags? #6207

C0nstantin opened this issue Mar 7, 2018 · 3 comments
Labels
bug C: Security
Milestone
1.3.5

Comments

@C0nstantin
Copy link

roundcubemail/program/steps/mail/func.inc

Line 166 in 981cd87

if (!strlen($mbox = rcube_utils::get_input_value('_mbox', rcube_utils::INPUT_GPC, true))) {

Hello, why not strip_tags get param '_mbox' ?

if sent /?_task=mail&_fra"med=2&_action=get&_mbox=<!--%20xxx><script>
it's commenting all page.
@alecpl
Copy link
Member

alecpl commented Mar 7, 2018

I confirm the issue, but the problem is not in this line.

@alecpl alecpl added this to the 1.3.5 milestone Mar 7, 2018
@alecpl
Copy link
Member

alecpl commented Mar 7, 2018

Using JSON_HEX_TAG flag for json_encode() in rcube_output::json_serialize() fixes the issue.

alecpl added a commit that referenced this issue Mar 7, 2018
@alecpl
Fix handling encoding of HTML tags in "inline" JSON output (#6207)
a451ad6
alecpl added a commit that referenced this issue Mar 7, 2018
@alecpl
Fix handling encoding of HTML tags in "inline" JSON output (#6207)
e5b7bcd
@alecpl
Copy link
Member

alecpl commented Mar 7, 2018

Fixed.

@alecpl alecpl closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: Security
Projects
None yet
Milestone
1.3.5
Development

No branches or pull requests
2 participants
@alecpl @C0nstantin